microsoft / kiota

OpenAPI based HTTP Client code generator

Home Page:https://aka.ms/kiota/docs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change C# code generation to follow the usual C# code style

Balkoth opened this issue · comments

Client library/SDK language

Csharp

Describe the solution you'd like

There is #4347 and #4348 but there are still the following cases left:

  • Put opening brace after namespace definition on new line image

  • Put opening brace after property definition on new line, if property has getter and setter image

  • Put spaces correctly around dictionary entries image

  • Remove trailing space after class definition image

Can submit a PR.

Hi @Balkoth
Thanks for using kiota and for reaching out.
Can you provide diffs for the changes you mentioned please? just to make sure we're on the same page before you do any work.

For diffs see op now.

Thanks for providing those. Yes it'd be beneficial as closer to C# conventions.
Please go ahead with a pull request.
And let us know if you need pointers.