Not consistent method parameter names
akordowski opened this issue · comments
Context / Scenario
All extension methods for Text-/TextEmbeddingGeneration are using the parameter ITextTokenizer? textTokenizer. The WithSemanticKernelTextGenerationService and the WithSemanticKernelTextEmbeddingGenerationService methods are using instead the ITextTokenizer? tokenizer parameter. For consistency it should be considered to rename the parameter.
If wished I could provide a PR for this.
What happened?
nothing
Importance
edge case
Platform, Language, Versions
all
Relevant log output
No response
if you send a PR, I would group this with the other one about anthropic cfg
PR is available #707