[Bug] Incorrect detection of embedding generator
vvdb-architecture opened this issue · comments
Context / Scenario
The KernelMemoryBuilder contains code to detect the client type to be built.
One of the conditions of building a SyncServerless or AsyncService client is the presence of an embedding generator (i.e. an implementation of ITextEmbeddingGenerator.
What happened?
The code in the aforementioned link contains:
var hasEmbeddingGenerator = (this._memoryServiceCollection.HasService<IMimeTypeDetection>());... whereas it should be:
var hasEmbeddingGenerator = _memoryServiceCollection.HasService<ITextEmbeddingGenerator>();Importance
a fix would make my life easier
Platform, Language, Versions
Latest
Relevant log output
n/a