Giters

microsoft / ghcrawler

Crawl GitHub APIs and store the discovered orgs, repos, commits, ...

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mark deleted entities

jeffmcaffer opened this issue · comments

commented

When we detect that something is deleted (e.g., some delete event), we need to mark the entity as deleted. likely this is reprocessing and adding a "deletedAt" property to the metadata.

  • be sure to factor that into subsequent data pipelines
  • decide if we need to filter deleted things at some point
commented

https://developer.github.com/v3/activity/events/types/

Handle "deleted" action for IssueCommentEvent, LabelEvent, MemberEvent, MilestoneEvent(?), PullRequestReviewCommentEvent, RepositoryEvent, TeamEvent.

The following events that may have "deleted" action are not used: ProjectCardEvent, ProjectColumnEvent, ProjectEvent (no need to do anything).

commented

Pull request #74

commented

The following events are not visible in event timeline:
LabelEvent, RepositoryEvent, TeamEvent, MilestoneEvent, TeamAddEvent, DeploymentEvent, DeploymentStatusEvent, MembershipEvent, MilestoneEvent, OrganizationEvent, PageBuildEvent, StatusEvent, IssueCommentEvent if action=deleted, PullRequestReviewCommentEvent if action=deleted, MemberEvent if action=removed (and not deleted as documented).
All these events will have to be processed directly from the webhook instead of the timeline.