microsoft / ghcrawler

Crawl GitHub APIs and store the discovered orgs, repos, commits, ...

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

orgList is not remapped to lowercase when changing via PATCH route

k----n opened this issue · comments

The problem lies here:

ghcrawler/lib/crawler.js

Lines 30 to 37 in 0ac1107

_reconfigure(current, changes) {
// ensure the orgList is always lowercase
const orgList = changes.find(patch => patch.path === '/orgList');
if (orgList) {
debug('orgList changed');
this.options.orgList = orgList.value.map(element => element.toLowerCase());
}
}

The path is not only /orgList

const orgList = changes.find(patch => patch.path === '/orgList');

When reassigning this.options.orgList, this.options.orgList.map(element => element.toLowerCase()) should be used and not orgList.value.map(element => element.toLowerCase()).

this.options.orgList = orgList.value.map(element => element.toLowerCase());