Giters

microsoft / ga4gh-tes

C# implementation of the GA4GH TES API; provides distributed batch task execution on Microsoft Azure

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CromwellTaskSubmitter misparses attempt-# in path

BMurri opened this issue · comments

commented

Describe the bug
When TES creates a task, if that task is a reattempt by Cromwell, it is not recognized as a Cromwell task.

Steps to Reproduce

  1. Run a task that will not succeed.
  2. Review the attempts.
  3. Notice that only the first attempt has an ID that is prefixed with the first part of the Workflow ID.

Expected behavior
Every Cromwell (and only Cromwell) tasks should be recognized as Cromwell tasks (and have an ID prefixed with the first part of the Workflow ID).

Additional context
Without correct identification, a task that fails and sets the rc file to a value != "0" will be incorrectly marked as a success, making this a regression, since we've historically looked for the rc file and used it to determine success or failure.