[BUG] environment_setup.sh continue to run even if conda env is not created
sambaiz opened this issue · comments
Taiki Sakamoto commented
Description
environment_setup.sh
failed to create conda environment but continue to run pip install
$ ./tools/environment_setup.sh
./tools/environment_setup.sh: line 6: conda: command not found
./tools/environment_setup.sh: line 9: conda: command not found
./tools/environment_setup.sh: line 12: conda: command not found
./tools/environment_setup.sh: line 12: conda: command not found
Obtaining file:///Users/sambaiz/microsoft/forecasting/fclib
Requirement already satisfied: pandas==0.23.4 in /usr/local/lib/python3.7/site-packages (from fclib==0.0.1) (0.23.4)
...
How do we replicate the bug?
Expected behavior (i.e. solution)
If an error occurs, stop running immediately.
Other Comments
Chenhui Hu commented
Resolving this issue as the enhancement has been merged to master.