Giters

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.

Home Page:https://aka.ms/fluentui-system-icons

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Is the direction of regular icon of "Text Number List" wrong?

liangdrime opened this issue · comments

commented

Summary

  • Outlook for Mac is using ic_fluent_text_number_list_20_regular in many scenarios, and the released version used in Outlook is 1.1.221.

  • This icon displays normal in LTR language.
    number-list-ltr

  • Then it is mirrored in RTL language, but the number "1,2,3" was flipped that seems not as expected. And we do not provide versions for languages like Arabic.
    number-list-rtl

Potential cause

  • In the metadata.json of Text Number List of the latest version 1.1.222, the directionType is unique and the singleton is LTR. Looks like this will result in a single language-direction icon for number list.
  • After looking into the Content.json of ic_fluent_text_number_list_20_regular which generated in iOS/FluentIcon/Assets/IconAssets.xcassets path, we're providing only one version of language-direction for this icon. So that Xcode can only use this icon and its mirror.
    image

Question/Expected

  • Is this as by design or a bug?
  • Do we need to provide various kinds of icon for LTR/RTL languages, just like what Apple does in SF Symbols?
    image

Cc @nickromano