unmatched div tag in menu-item.template.ts

Question

oldoldman opened this issue 9 months ago · comments

Hi guys,
I've double checked that </div> at this line has no matching start tag. Many thanks!!!

Nathan Brown · Answer 1 · Thu Sep 28 2023 01:01:58 GMT+0800 (China Standard Time)

@chrisdholt @bheston could this be addressed as a part of the ongoing template updates or should we get a fix in sooner?

Kamal Rohra · Answer 2 · Wed Oct 04 2023 23:22:42 GMT+0800 (China Standard Time)

Hello, I would like to work on this issue

Nathan Brown · Answer 3 · Thu Oct 05 2023 02:16:07 GMT+0800 (China Standard Time)

Hello, I would like to work on this issue

You're more than welcome to take this. I have gone ahead and assigned this to you.

Rahul Kumar · Answer 4 · Sat Oct 07 2023 17:34:34 GMT+0800 (China Standard Time)

@KingOfTac Hi, it seems he's not working on this issue as he's taking so much time for a pretty easy fix. should i work on this?

Kamal Rohra · Answer 5 · Sat Oct 07 2023 17:47:30 GMT+0800 (China Standard Time)

Hey I have made the required changes just creating a pr wasn't well for a couple of days sorry for the delay

Brian Heston · Answer 6 · Sun Oct 08 2023 00:03:02 GMT+0800 (China Standard Time)

Agreed we should get this in aside from the larger template update. I've commented on the PR.