microsoft / appcenter-sdk-react-native

Development repository for the App Center SDK for React Native

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`Crashes.d.ts` type definition is incorrect

stefan-schweiger opened this issue Β· comments

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch appcenter-crashes@5.0.0 for the project I'm working on.

Type definition does not match the actual code. While I think there should be the possibility for innerExceptions at least for now the type definition should match the actual implementation.

Here is the diff that solved my problem:

diff --git a/node_modules/appcenter-crashes/Crashes.d.ts b/node_modules/appcenter-crashes/Crashes.d.ts
index 9185f12..d5bd12d 100644
--- a/node_modules/appcenter-crashes/Crashes.d.ts
+++ b/node_modules/appcenter-crashes/Crashes.d.ts
@@ -24,10 +24,9 @@ export class ErrorAttachmentLog {
 
 export class ExceptionModel {
   wrapperSdkName: string;
-  innerException: ExceptionModel[];
   type: string;
   message: string;
-  stacktrace: string;
+  stackTrace: string;
   public static createFromError(error: Error): ExceptionModel;
   public static createFromTypeAndMessage(type: string, message: string, stacktrace: string): ExceptionModel;
 }

This issue body was partially generated by patch-package.

Hi @stefan-schweiger and thank you for reaching out to us. I submitted a pull request to fix this.

Hello @stefan-schweiger, this fix available in new 5.0.1 version.