Giters

microsoft / SqlScriptDOM

ScriptDOM/SqlDOM is a .NET library for parsing T-SQL statements and interacting with its abstract syntax tree

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TSqlParser.Create() should be static, SqlScriptGenerator should have a similar factory method.

poizan42 opened this issue · comments

commented

TSqlParser.Create() is a factory method, but you still need to create an instance in order to use it to create an instance...

https://github.com/microsoft/SqlScriptDOM/blob/8c89e442ccde2b01398ff66f8fdfd0eaf6ae0160/SqlScriptDom/Parser/TSql/TSqlParser.cs#L36C12-L36C12

I would also like to suggest adding a similar (but static) factory method to SqlScriptGenerator, taking an SqlScriptGeneratorOptions argument.