Giters

microsoft / SqlScriptDOM

ScriptDOM/SqlDOM is a .NET library for parsing T-SQL statements and interacting with its abstract syntax tree

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Antlr env var step should be clearer

Charles-Gagnon opened this issue · comments

commented

It currently says Create environment variable named Antlr2Exe pointing to the installation path.. There's a couple of issues with this:

  1. That should be pointing to the batch file, not the "installation path"
  2. The env var indicates it's an exe, but it isn't (it's a batch file)
commented

I'm going to try to automate this step as well, so it's more simple to run the repo

commented

When you do that see if you can use https://www.nuget.org/packages/Antlr or something so the user doesn't have to install anything. This might involve updating the antlr version - not sure if there's a reason it specifies 2.7.5 but if we can update that too that'd be good anyways.

commented

Unfortunately, I don't think we can use Antlr3 at the moment, because they made significant changes on how the AST is constructed, and we would have to update our existing grammar rules.
Here's an issue tracking the migration to Antlr3 #15