microsoft / SparseSC

Fit Sparse Synthetic Control Models in Python

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Confidence Interval in utils.metrics_utils.py breaks

tom-flamelit opened this issue · comments

Line number of issue:

Current situation:
N0 = 107, N1 = 305 results in a very large alpha_ind value in line 295. This exceeds the value of 0.5*(n_pl-1) in resulting in line 302 for outside_avg_effect being outside of bounds.

The major issue is the calculation of p2min = 2/n_pl

Thanks for finding this issue! I've fixed it in acd2ad1.