microsoft / SparseSC

Fit Sparse Synthetic Control Models in Python

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix NameError in estimate_effects

wofein opened this issue · comments

Hello!

I believe that the variable name change introduced in this commit also introduced a bug. The variable was renamed from cv_folds to cf_folds but there are still two instances of cv_folds in estimate_effects. This is causing a NameError. I have also added a PR if you want to just change to the new name: #35

Hey, thanks for reporting this! Your PR was missing another instance of the renamed variable so I pushed through my own commit.