Unnecessary awaiting on event implementations
MihaMarkic opened this issue · comments
For example:
private async void OpenDoorAsync()
{
await NavigationService.NavigateToPopupAsync<OpenDoorViewModel>(true);
}
This code doesn't need await nor async. In fact it generates unnecessary code bloat behind the scenes. I'd do it like
private void OpenDoorAsync()
{
var ignore=NavigationService.NavigateToPopupAsync<OpenDoorViewModel>(true);
}
/cc @jsuarezruiz
First of all, thank you for your contribution.
I have sent a PR with changes in some asynchronous commands to avoid making unnecessary use of async void.
PR #7 Merged! Thx to all!!!