Linux build failure due to -WError when building SPIRV-Tools
Jjagg opened this issue · comments
Describe the bug
SPIRV-Tools is compiled with the -WError flag. Building a clean clone of the repo with either clang or gcc fails because of the warning reported in KhronosGroup/SPIRV-Tools#1541. Not sure why CI builds don't run into this.
To Reproduce
Run python BuildAll.py ninja gcc
or python BuildAll.py ninja clang
.
Clang version: 7.0.0 (tags/RELEASE_700/final)
Gcc version: 8.2.1 20181127 (GCC)
Expected behavior
Cloning a build and running the python build script Just Works.
Additional context
I don't think ShaderConductor needs to set -WError. This can be disabled by setting SPIRV_WERROR=OFF
.
Thanks for reporting. CI's using gcc8, somehow it doesn't have this problem. The SPIRV-Tools issue you mentioned about was fixed hours ago. I'll try to update SPIRV-Tools to solve this.
Awesome, thanks for the quick response (to all my issues)!