microsoft / Qcodes

Modular data acquisition framework

Home Page:http://microsoft.github.io/Qcodes/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ignored exception on ci in windows related to monitor and socket.

jenshnielsen opened this issue · comments

This may be related to the intermitted failures of monitor tests on windows

Observing the following traceback

Exception ignored in: <socket.socket fd=1116, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 55090), raddr=('127.0.0.1', 55091)>
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\threading.py", line 917, in run
    self._target(*self._args, **self._kwargs)
ResourceWarning: unclosed <socket.socket fd=1116, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 55090), raddr=('127.0.0.1', 55091)>

Had a look at the logs from running the tests and the websockets documentation. Its not clear that we are doing anything wrong. However unlike their examples we have to guard against connection closed errors within the async server function. It would probably make sense to use Open telemetry threading to see if we can understand better how the threads interact open-telemetry/opentelemetry-python-contrib#2253