microsoft / Network-Performance-Visualization

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

% Change formulas break often

lgonzalez876 opened this issue · comments

There's some faulty logic for determining which cells to compare for the % change column of (at least) the Format-Stats table. Issue here is the data formatter is trying to guess the row/column each cell will end up in on the final Excel worksheet. Though possible, its complicated and easy to get wrong. Also the Format- functions are designed so that they can be called in any order, so the structure (# of pages, what order charts are in on a given page) can be controlled at a high level by the Network-Performance-Visualization module. The current implementation of % Change formulas assumes a specific order (changing the order may be what caused this originally-functional implementation to break).

Proposed Fix:
Add some token (maybe "" and "") which is detected by the excel plotter function and then swapped with the corresponding value for that cell. Thus, the formula of a % change cell will be set by the excel plotter which will know exactly which cell it is being written to.

Fixed