Giters

microsoft / IIS.ServiceMonitor

An entrypoint process for running IIS in Windows containers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Environment variable names are converted to uppercase in the container

vjgn opened this issue · comments

commented

ServiceMonitor converts the environment variable names to upper case when adding to the app pool process.
Below line in IISConfigUtil.cpp seems to do a in place conversion of the environment name to upper case. FilterEnv(filter, CharUpper(pstrNameCheck), pstrValue)
This is causing environment variable replacement using ConfigBuilders to fail unless we change all AppSetting keys to be upper case which is not ideal.

commented

I will make a fix in this week.

commented

Any ETA on the fix. Thank you.

commented

I have commented on your PR.
#33

commented

Any news on a release, or do I need to compile this myself?

I'm using the mcr.microsoft.com/dotnet/framework/aspnet:4.7.2-windowsservercore-ltsc2016 container as a base image. According to the Dockerfile in the repo for that image, they are using v 2.0.1.6 of service monitor which is signed on october 5 2018. Is this fix supposed to be in that binary, because I'm still getting uppercase environment variables in the applicationhost.config.

commented

@bariscaglar looks like this slipped through the cracks. Do you have someone who can take a look at releasing this?

commented

Actually looks like I misspoke. 2.0.1.6 has this change in it already

commented

Jumped the gun on that. Looked back on the build history. 2.0.1.6 was built from 5f6d967