Unused inc folder
hansmbakker opened this issue · comments
A lot of the samples add the ..\inc folder as additional includes folder, while for most samples this folder does not exist.
Examples:
DMF/DmfSamples/SwitchBar4/SwitchBar4.vcxproj
Line 133 in 465ecb1
I am planning on cleaning up the samples' projects in the next few days.
When I do I will check that. However all samples should compile correctly
without any change as I do that almost every day. If not, let me know.
Also, please see the slide deck i added recently. It has some slides
devoted to steps to building Modules. Look at "Part 2".
…On Sun, Dec 29, 2019, 14:45 Hans Bakker ***@***.***> wrote:
A lot of the samples add the inc folder as additional includes folder,
while for most samples this folder does not exist.
Examples:
https://github.com/microsoft/DMF/blob/465ecb1953eea0024c98b821b280a6eed2f05223/DmfSamples/VHidMini2Dmf/User/VHidMini2DmfU.vcxproj#L103
https://github.com/microsoft/DMF/blob/master/DmfSamples/SwitchBar4/SwitchBar4.vcxproj#L133
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#92?email_source=notifications&email_token=AHY5IWRM7C77LMOI7FAMSSTQ3ER7DA5CNFSM4KBDXDJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDGXUJA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHY5IWT2DLOIHC272UWUPXLQ3ER7DANCNFSM4KBDXDJA>
.
Agree that they compile fine, I just noticed it and decided to share my findings.
Thank you for you notes, Hans. Look for an update this week or early next week due to holidays.
I understand, enjoy the New Year celebration! Happy New Year :)
Fixed in Release 1.1.39. Thank you for your feedback.