Unused config param in DMF_VirtualHidKeyboard module
serkodev opened this issue · comments
These config param in DMF_VirtualHidKeyboard module are not been used:
HidDescriptorLengthHidDescriptor
Related file:
https://github.com/microsoft/DMF/blob/v1.1.108/Dmf/Modules.Library/Dmf_VirtualHidDeviceVhf.h
https://github.com/microsoft/DMF/blob/v1.1.108/Dmf/Modules.Library/Dmf_VirtualHidDeviceVhf.c
https://github.com/microsoft/DMF/blob/v1.1.108/Dmf/Modules.Library/Dmf_VirtualHidDeviceVhf.md
Is there any purpose for keeping it or just placeholder for deprecated config?
I can help to submit a pull request for cleaning the code (including the related sample) if it is really unused code.
It appears this is a holdover from the original version of virtual HID support in DMF when it used the DMF_VirtualHidMini Module (the legacy method before VHF support).
From what I can see, VHF does not need that...But now I am wondering how IOCTL_HID_GET_DEVICE_DESCRIPTOR is supported in VHF,
You can see how it was used previously in DMF_VirtualHidMini#1208. Let me verify tomorrow, but I think you can go ahead and create a PR.
Note: Some people are able to create PRs here and others are not. Please try it and let me know.
Thank you for your feedback. We really appreciate it.
Hi, we have corrected this issue internally and we will merge it here this week. So, please don't make a PR to save your time. Thank you for the feedback.
Cool, thanks for working on it. Sorry for the late response of my personal work.
No need to apologize. I think we will make an update by end of week.