Giters

microsoft / CromwellOnAzure

Microsoft Genomics implementation of the Broad Institute's Cromwell workflow engine on Azure

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Changes to values-template.yaml are invisible during upgrades

BMurri opened this issue · comments

commented

Describe the bug
As a dev, I expect that if I make a change to values-template.yaml that change will be reflected in the yaml files that Heml applies deployments no matter if they are initial deployments or upgrades. Note that the same general issue also exists in the TES deployer.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Create a deployment using the CoA deployer.
  2. Change the accountName and sasToken of the externalSasContainers property in values-template.yaml.
  3. Rebuild the deployer code and upgrade the deployement generated in step 1.
  4. Check the settings of the kubernetes cluster. Note that all properties related to the external sas containers remain as they were in the initial depoyment.

Expected behavior
I expected that they would either be replaced or would be added to. Ideally replaced.

Deployment details: (any information you can provide would be helpful):

Additional context
This issue prevents easily replacing a SAS token via update, among other things.