microlinkhq / keyvhq

Simple key-value storage with support for multiple backends.

Home Page:https://keyvhq.js.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Export ioredis from @keyvhq/redis package

BryceMehring opened this issue · comments

ioredis should be exported from the @keyvhq/redis package so that we can ensure that we are using the same version of ioredis required by this package. On

if (input instanceof Redis) return input
we are checking if the argument is an ioredis Redis instance but that only works if the version is the same.

Agree; can you make a PR? 🙏

A couple issues with the fix:

  1. Typescript definitions need to be updated with the named export: https://github.com/microlinkhq/keyvhq/blob/master/packages/redis/src/index.d.ts#L24
  2. Readme of redis package needs to be updated to show importing redis from this package: https://github.com/microlinkhq/keyvhq/blob/master/packages/redis/README.md

Is e819f7a going to be published to npm?