Should use npm 5?

Question

Should use npm 5?

graciano opened this issue 7 years ago · comments

New npm version 5 has a new package-lock.json file that should be commited.
When I ran npm install in my machine with this project I noticed it hasn't this file yet. Since I'm planning on adding something here, should I make another PR creating the new file, or use an older version of npm?

Charlike Mike Reagent · Answer 1 · Fri Jul 28 2017 01:18:09 GMT+0800 (China Standard Time)

Hi! ✋

It's not a problem if/to commit it.

Thanks for asking.

Ryan Castner · Answer 2 · Fri Jul 28 2017 02:33:43 GMT+0800 (China Standard Time)

we should probably have a separate PR for this independent of any added libs

Graciano · Answer 3 · Fri Jul 28 2017 02:46:07 GMT+0800 (China Standard Time)

@audiolion Agreed. Since I've already done it locally, I'm sending it in #918. And the addition of my lib will wait until I write a better readme for it. In another PR.