CI job for pull requests that runs make
orbitbot opened this issue · comments
To reduce manual labor required and improve the feedback loop for outside contributors, I'd suggest setting up a CI instance on f.e. Travis that would run functionality identical to the make command. I have not looked at the entire lib subfolder, but there's probably not that much there that couldn't be automated.
@orbitbot I'm guessing this would be a good question for @tunnckoCore? (He's a @microjs member, so I assume he has admin privileges, and he has had significant recent GitHub activity.)
@isiahmeadows thanks for the ping, these pings aren't problem for me like for some other devs in the community, haha. Another story is that i'm pretty busy currently and trying to get all things done.
@orbitbot don't see the point cuz there's no tests currently? Also we need too much work to revive the project and setup more automation on adding/editing more libs, testing and rebuilding the website.
don't see the point cuz there's no tests currently?
The idea is to not do tests as such, but use the CI server to run the make command. This would almost immediately inform anyone trying to make a PR if their contribution does not conform to the rules set forth by the project for whatever reason, and they can then make adjustments or immediately close the PR.
Also we need too much work to revive the project and setup more automation on adding/editing more libs, testing and rebuilding the website.
I'm not sure how to read this, do you mean that the amount of work involved is prohibitive so essentially no one is going to update the project outside of some PRs, or you thought I suggested adding tests for make and that doesn't feel important?
Anyway, got it. Maybe we should just add make to npm test script?
hmm, also we need some default in the Makefile, i believe it is called PHONY, or something?
It's the first goal that appears in the makefile.
https://www.gnu.org/software/make/manual/html_node/Goals.html
On Tue, Nov 1, 2016, 05:13 Charlike Mike Reagent notifications@github.com
wrote:
Anyway, got it. Maybe we should just add make to npm test script?
hmm, also we need some default in the Makefile, i believe it is called
PHONY, or something?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#874 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AERrBLgwyldNCLLUS_3EiACNkWODDoBJks5q5wKhgaJpZM4KDpu1
.
Yea. Okey, no problems for me. PRs welcome i have time for review and merge, don't have the time to think and write what we needs exactly.
I have added a travis.yml build in PR #882 . It allows PR reviewers to check the build, if we keep the data.js file up to date there should only be one error, I might actually change the npm test to do ./build.js -v | grep ERROR|WARNING. I need to modify build.js to output errors on those responses so the build 'fails'.
The CI process now hangs as it is expecting someone to enter Github credentials, could someone set the following encrypted environment variables in the Travis UI:
- GH_USER
- GH_TOKEN
This will mean that ./build.js will no longer prompt for credentials.
Thanks
I will look into it this weekend -- fixed