promise.then(...).catch(...).done is not a function

Question

promise.then(...).catch(...).done is not a function

atus opened this issue 5 years ago · comments

Alan Tus commented 5 years ago

I get the error below. As part of debugging this I did the following:

reinstalled node and npm with correct versions
reinstalled pimatic-hap from pimatic
reinstalled pimatic-hap from git and ran npm install from its directory

If I disable all devices I can set up a new home. As soon as I add a simple GpioSwitch I get the error below.

pimatic version 0.9.48
Node.js version 4.9.1
pimatic-hap version 0.11.1

I do not use tradfri where other people have reported errors previously.

Interestingly, when I add a single PowerSwitch I get this error but I can control the switch from Home app. The error appears if I open the app or click on the control.

22:32:30.574 [pimatic-hap] [fa:fe:db:e4:36:2c] HAP Request: POST /pair-verify
22:32:30.582 [pimatic-hap] [fa:fe:db:e4:36:2c] Pair verify step 1/2
22:32:30.994 [pimatic-hap] [fa:fe:db:e4:36:2c] HAP Request: POST /pair-verify
22:32:31.000 [pimatic-hap] [fa:fe:db:e4:36:2c] Pair verify step 2/2
22:32:31.010 [pimatic-hap] [fa:fe:db:e4:36:2c] Client 14101D25-D25F-46BD-B6C6-5ABADB6585E0 verification complete
22:32:31.147 [pimatic-hap] [fa:fe:db:e4:36:2c] HAP Request: GET /accessories
22:32:31.193 [pimatic-hap] [fa:fe:db:e4:36:2c] HAP Request: PUT /characteristics
22:32:31.199 [pimatic-hap] [Pimatic HomeKit Bridge] Processing characteristic set: [{"aid":2,"iid":9,"ev":true}]
22:32:31.203 [pimatic-hap] [Pimatic HomeKit Bridge] Registering Characteristic "Reachable" for events
22:32:31.881 [pimatic-hap] [fa:fe:db:e4:36:2c] HAP Request: PUT /characteristics
22:32:31.884 [pimatic-hap] [Pimatic HomeKit Bridge] Processing characteristic set: [{"aid":2,"iid":15,"ev":true}]
22:32:31.887 [pimatic-hap] [Pimatic HomeKit Bridge] Registering Characteristic "On" for events
22:32:31.995 [pimatic-hap] [fa:fe:db:e4:36:2c] HAP Request: PUT /characteristics
22:32:31.998 [pimatic-hap] [Pimatic HomeKit Bridge] Processing characteristic set: [{"aid":2,"iid":15,"ev":true}]
22:32:32.000 [pimatic-hap] [Pimatic HomeKit Bridge] Registering Characteristic "On" for events
22:32:34.354 [pimatic-hap] [fa:fe:db:e4:36:2c] HAP Request: GET /characteristics?id=2.15
22:32:34.363 [pimatic-hap] [Pimatic HomeKit Bridge] Getting value for Characteristic "On"
22:32:34.427 [pimatic] An uncaught exception occurred: TypeError: promise.then(...).catch(...).done is not a function
22:32:34.427 [pimatic]>    at PowerSwitchAccessory.BaseAccessory.handleReturnPromise (/home/pi/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:75:10)
22:32:34.427 [pimatic]>    at PowerSwitchAccessory.handleReturnPromise (/home/pi/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:1:1)
22:32:34.427 [pimatic]>    at null.<anonymous> (/home/pi/pimatic-app/node_modules/pimatic-hap/accessories/switch.coffee:39:12)
22:32:34.427 [pimatic]>    at emitThree (events.js:97:13)
22:32:34.427 [pimatic]>    at null.emit (events.js:175:7)
22:32:34.427 [pimatic]>    at null.Characteristic.getValue (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Characteristic.js:142:10)
22:32:34.427 [pimatic]>    at Bridge.<anonymous> (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Accessory.js:706:20)
22:32:34.427 [pimatic]>    at Array.forEach (native)
22:32:34.427 [pimatic]>    at Bridge.Accessory._handleGetCharacteristics (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Accessory.js:670:8)
22:32:34.427 [pimatic]>    at emitMany (events.js:108:13)
22:32:34.427 [pimatic]>    at HAPServer.emit (events.js:182:7)
22:32:34.427 [pimatic]>    at HAPServer._handleCharacteristics (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/HAPServer.js:926:10)
22:32:34.427 [pimatic]>    at HAPServer.<anonymous> (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/HAPServer.js:209:39)
22:32:34.427 [pimatic]>    at emitNone (events.js:67:13)
22:32:34.427 [pimatic]>    at IncomingMessage.emit (events.js:166:7)
22:32:34.427 [pimatic]>    at endReadableNT (_stream_readable.js:923:12)
22:32:34.427 [pimatic]>    at nextTickCallbackWith2Args (node.js:511:9)
22:32:34.427 [pimatic]>    at process._tickDomainCallback (node.js:466:17)
22:32:34.427 [pimatic]> This is most probably a bug in pimatic or in a module, please report it!
22:32:34.437 [pimatic] shutting pimatic down...

newschooler · Answer 1 · Tue May 21 2019 07:15:15 GMT+0800 (China Standard Time)

Same error on my site

An uncaught exception occurred: TypeError: promise.then(...).catch(...).done is not a function
    at PowerSwitchAccessory.BaseAccessory.handleReturnPromise (/home/pi/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:75:10)
    at PowerSwitchAccessory.handleReturnPromise (/home/pi/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:1:1)
    at null.<anonymous> (/home/pi/pimatic-app/node_modules/pimatic-hap/accessories/switch.coffee:39:12)
    at emitThree (events.js:97:13)
    at null.emit (events.js:175:7)
    at null.Characteristic.getValue (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Characteristic.js:142:10)
    at Bridge.<anonymous> (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Accessory.js:706:20)
    at Array.forEach (native)
    at Bridge.Accessory._handleGetCharacteristics (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Accessory.js:670:8)
    at emitMany (events.js:108:13)
    at HAPServer.emit (events.js:182:7)
    at HAPServer._handleCharacteristics (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/HAPServer.js:926:10)
    at HAPServer.<anonymous> (/home/pi/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/HAPServer.js:209:39)
    at emitNone (events.js:67:13)
    at IncomingMessage.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:923:12)
    at nextTickCallbackWith2Args (node.js:458:9)
    at process._tickCallback (node.js:372:17)
 This is most probably a bug in pimatic or in a module, please report it!

Michael Kotten · Answer 2 · Tue May 21 2019 13:06:02 GMT+0800 (China Standard Time)

@newschooler Can you tell which type of device is used?

Michael Kotten · Answer 3 · Wed May 22 2019 17:09:34 GMT+0800 (China Standard Time)

@atus I suspect the pimatic-gpio plugin, because it was updated recently. Could you try to revert back to the version before, which would be 0.9.0? Especially is suspect pimatic/pimatic-gpio@35b6472

newschooler · Answer 4 · Thu May 23 2019 05:29:04 GMT+0800 (China Standard Time)

@newschooler Can you tell which type of device is used?

Sorry, it's the GpioSwitch as well. I will try to revert and report then.

edit: @michbeck100 I just moved back to pimatic-gpio 0.9.0 plugin and the error is gone.

Alan Tus · Answer 5 · Sat Jun 01 2019 22:54:02 GMT+0800 (China Standard Time)

confirming that downgrading to pimatic/pimatic-gpio 0.9.0 solves the issue

Michael Kotten · Answer 6 · Tue Jun 18 2019 05:07:07 GMT+0800 (China Standard Time)

Version 0.11.2 should fix this issue. I had the same problem with pimatic-sysinfo, so it was easy to find the problem then.

Marcus Wittig · Answer 7 · Tue Jun 18 2019 14:25:14 GMT+0800 (China Standard Time)

Why do you use done() in this context? It should not be used with bluebird promises and it is not part of the standard for native promise. If I recap this correctly done() is used as part of Q, but Q promises should be wrapped by the plugin as much as possible, as the are considered harmful

Michael Kotten · Answer 8 · Tue Jun 18 2019 14:31:40 GMT+0800 (China Standard Time)

@mwittig to be honest, I'm not a JS professional, I've just seen other plugins and pimatic itself using done() (see here) Would be great if you have an example how to use it right, and I will change it for the next release

Marcus Wittig · Answer 9 · Tue Jun 18 2019 18:19:29 GMT+0800 (China Standard Time)

Well, me neither. See

"Awaiting a promise" in https://www.promisejs.org
http://bluebirdjs.com/docs/api/done.html

Needs further investigation which type of promise it is, as native and bluebird promise should have done() defined. Also it should be investigate which strategy is the best to avoid such issues:

Wrap-up Promise like you did, or
Polyfill which might be a generic solution, e.g. https://www.promisejs.org/polyfills/promise-done-7.0.4.js
Neglect done().

The use in the pimatic code itself is for historical reasons

Michael Kotten · Answer 10 · Fri Sep 20 2019 02:57:25 GMT+0800 (China Standard Time)

Should be solved together with #78