Basic get (pulling API) always sends acks
boechat107 opened this issue · comments
Andre Boechat commented
I tried to use langohr.basic/get
with explicit ack, but it seems to not work as expected. Acks are sent anyway.
I looked for a test of the function and I found this code, but I didn't understand its idea. Shouldn't it send some explicit ack?
Michael Klishin commented
Your understanding is right, looks like an incorrect test and a possible bug.
Michael Klishin commented
I can't reproduce this in the REPL and modifying this test to use automatic acknowledgements makes it fail as expected. The test now sends a basic.ack
, this is a decent quick fix for it.