michaelforney / samurai

ninja-compatible build tool written in C

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

New release including commit fb61f22c7e690715d309c41812412c4f432ef53a

anonyno opened this issue · comments

i think fixing segfault (and the 2 CVEs) is worth a new release.

It's been on my to-do list for a while, but I haven't found the time. If you (or anyone else) would like to help make a new release happen, you could help me out by doing a series of builds with samurai master of several large projects using a variety of build systems (GN, cmake, meson) then report back about whether you've found any issues. Good examples are llvm, chromium, and mesa. That would certainly save me some time.

FWIW, samurai is a tool that is designed to run arbitrary commands from a text file. A NULL-dereference triggered by an invalid input isn't exactly cause for concern, in my opinion.

FWIW, samurai is a tool that is designed to run arbitrary commands from a text file. A NULL-dereference triggered by an invalid input isn't exactly cause for concern, in my opinion.

yes, that is good point. i didn't read cves until now (too many hard words).