Support PHP 7.x

Question

Support PHP 7.x

dany-eudes opened this issue 3 years ago · comments

Dany Eudes commented 3 years ago

Could you please downgrade to PHP 7.x ?
Maybe PHP 7.4...

Thank you for shared laravel-formatters. This will very very useful for Laravel community.

Michael Rubél · Answer 1 · Sun Dec 19 2021 15:22:47 GMT+0800 (China Standard Time)

Hi,

Unfortunately, but I'm not going to maintain legacy versions.
Of course, you're free to open PR that adds PHP 7.4 support, but your changes should be compatible with PHP 8.1.

Dany Eudes · Answer 2 · Sun Dec 19 2021 23:16:41 GMT+0800 (China Standard Time)

Thank you, Michel! I appreciate your awesome work!

Dany Eudes · Answer 3 · Mon Dec 20 2021 03:20:05 GMT+0800 (China Standard Time)

I checked the compatibility for PHP 7.4 and I came to the conclusion that I would only need to tweak composer.json and comment out the mixed pseudo-type, which is a new feature of PHP 8.

That way, only one of the tests will fail and that's even before the code throws the expected error exception.

I don't know if you would change your mind and you would support PHP 7.4 as well, if so this could be the starting point.

Best Regards.

Michael Rubél · Answer 4 · Mon Dec 20 2021 03:42:20 GMT+0800 (China Standard Time)

@dany-eudes
You can open a pull request so we can see if something fails.