The effects do not produce any output until explicitly initialized.

Question

The effects do not produce any output until explicitly initialized.

yaremenko8 opened this issue 2 years ago · comments

LORE 1.0.22
The effect chain produces no sound output until you actually set each individual effect manually.
This issue occurs in the following four scenarios:

LORE is launched (standalone/VST synth/VST effect)
LORE is disabled and re-enabled in DAW (VST synth/VST effect)
Options --> Reset to default state
Options --> Load a saved state... (+ proceeding to actually select a file)

Micah Frank · Answer 1 · Mon Nov 21 2022 06:00:06 GMT+0800 (China Standard Time)

Hi — sorry I missed this. I am only now seeing the few issues posted here.
is this still an issue? Are you on Windows or OSX?

Sy Brand · Answer 2 · Tue Nov 22 2022 00:59:43 GMT+0800 (China Standard Time)

I have this issue, or at least a very similar one. If I have any effects set, then I export the audio in Ableton, then the effects produce no output, and to get them to work again I need to nudge the settings of all of them. I'm on Windows.

Sy Brand · Answer 3 · Tue Nov 22 2022 21:31:57 GMT+0800 (China Standard Time)

I don't really understand how CSound and Cabbage work, but it seems like the effects only get loaded in when the user changes selection on one of the slots, but the current selections should also be loaded on initialization?

Edit: scratch that, loadeffects gets called fine when exporting, but it gets an empty effect name

Sy Brand · Answer 4 · Sat Nov 26 2022 04:52:26 GMT+0800 (China Standard Time)

I did a reaaaaaally deep dive of this today and discovered it's actually a bug in Cabbage.

https://github.com/rorywalsh/cabbage/blob/develop/Source/Audio/Plugins/CsoundPluginProcessor.cpp#L483

On the line above, filetype should be fileType. This bug prevents the data from combo boxes being correctly restored to the CSound channels when Ableton does an export.

I'm going to send Cabbage a PR.

Sy Brand · Answer 5 · Sat Nov 26 2022 05:03:43 GMT+0800 (China Standard Time)

I sent them a PR: rorywalsh/cabbage#137

Micah Frank · Answer 6 · Sun Nov 27 2022 08:02:31 GMT+0800 (China Standard Time)

Wow - thanks for doing the deep digging here. I’m going to test it out myself next week, will follow up with Rory too.

…

On Fri, Nov 25, 2022 at 4:03 PM Sy Brand ***@***.***> wrote: I sent them a PR: rorywalsh/cabbage#137 <rorywalsh/cabbage#137> — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARBWJI4CLPNGWDKNZ3VARTWKESTTANCNFSM573UXVCA> . You are receiving this because you commented.Message ID: ***@***.***>

Sy Brand · Answer 7 · Sun Nov 27 2022 17:25:13 GMT+0800 (China Standard Time)

There seem to be a few issues with the current development version of Cabbage for Lore. There's the one in my PR, but to make the ComboBox work properly, there's also a few lines which need uncommented, and a recent commit removes setting the current working directory, which breaks the ComboBox population. This branch has all the necessary changes for it to work: https://github.com/TartanLlama/cabbage/tree/lore

Rory Walsh · Answer 8 · Mon Nov 28 2022 17:23:29 GMT+0800 (China Standard Time)

Thanks @TartanLlama As Micah knows only too well, comboboxes have been a constant pain for us. I'll go over that PR and we can take it up from there. 👍

Rory Walsh · Answer 9 · Tue Nov 29 2022 23:54:49 GMT+0800 (China Standard Time)

@TartanLlama would you mind making a PR for the branch you're using to sort the combobox issues in Lore? I'm swamped with other work at the moment and haven't had a chance to look into this, so a gentle nudge by the way of a PR would be most appreciated 👍

Sy Brand · Answer 10 · Wed Nov 30 2022 16:13:36 GMT+0800 (China Standard Time)

@rorywalsh can do! One issue is that a recent commit which removed CWD setting breaks part of the functionality, so my changes are based on an earlier commit: rorywalsh/cabbage@9c449f8

From this issue (rorywalsh/cabbage#136) I understand that it creates issues with some hosts. So perhaps the best option is for me to:

Rebase my changes onto HEAD
Modify the Combo Box populate code to:
- Still avoid setting CWD
- If the path used is relative, assume it is relative to the current open file

Rory Walsh · Answer 11 · Wed Nov 30 2022 17:56:14 GMT+0800 (China Standard Time)

That sounds good to me. The CWD issue was a long standing hack that is best avoided. I wonder could that change have been the thing that broke Lore?

…

On Wed 30 Nov 2022, 8:13 a.m. Sy Brand, ***@***.***> wrote: @rorywalsh <https://github.com/rorywalsh> can do! One issue is that a recent commit which removed CWD setting breaks part of the functionality, so my changes are based on an earlier commit: ***@***.*** <rorywalsh/cabbage@9c449f8> From this issue (rorywalsh/cabbage#136 <rorywalsh/cabbage#136>) I understand that it creates issues with some hosts. So perhaps the best option is for me to: - Rebase my changes onto HEAD - Modify the Combo Box populate code to: - Still avoid setting CWD - If the path used is relative, assume it is relative to the current open file — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUQWGNF3FUXB6INWRNHUHTWK4EDZANCNFSM573UXVCA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Sy Brand · Answer 12 · Wed Nov 30 2022 21:45:24 GMT+0800 (China Standard Time)

Okay, I created PRs in both repos to address the combo box issues:
rorywalsh/cabbage#138
#13

Rory Walsh · Answer 13 · Wed Nov 30 2022 21:50:48 GMT+0800 (China Standard Time)

Merged 👍 Thanks again for this :) The CI build should be ready shortly for testing..

Rory Walsh · Answer 14 · Wed Nov 30 2022 21:56:24 GMT+0800 (China Standard Time)

Actually, I just looked over this, and the following change seems like it might break something:
https://github.com/rorywalsh/cabbage/pull/138/files#diff-93ccddd7cd131680e1799beded76ee70034eab9d8281ad07834dea95327b34ffL505

In the original code the full file, path and extension is returned, but now only the filename is returned? On the other hand, the extension can be got on the Csound side. I'm just concerned it will break existing instruments..

Sy Brand · Answer 15 · Wed Nov 30 2022 22:05:56 GMT+0800 (China Standard Time)

Previously I think the exact contents of that channel were a bit inconsistent, e.g. this line sends just the filename from the Combo Box https://github.com/rorywalsh/cabbage/blob/develop/Source/Widgets/CabbageComboBox.cpp#L97

I do think that one line I uncommented (this one https://github.com/rorywalsh/cabbage/blob/develop/Source/Widgets/CabbageComboBox.cpp#L401) needs changed to match though.

Rory Walsh · Answer 16 · Fri Dec 02 2022 18:32:53 GMT+0800 (China Standard Time)

@TartanLlama can you confirm that these latest changes let you work with the Lore effects? I'm still not sure it resolves the problems reported here.

Sy Brand · Answer 17 · Fri Dec 02 2022 19:08:16 GMT+0800 (China Standard Time)

@rorywalsh it does, but requires these changes to Lore to fix the relative path compileorc thing

Rory Walsh · Answer 18 · Fri Dec 02 2022 19:21:53 GMT+0800 (China Standard Time)

I just looked through the changes now after confirming it works. Great stuff. On behalf of all the Cabbage and Lore, users thank you for sorting this out 💪