Refactoring Suggestion
FreebieStock opened this issue · comments
FreebieStock commented
Each feed type should be a separate class, instead of checking all the time what type of feed it is:
if($type == 'RSS 1')
...
elseif($type == 'RSS 2')
elseif($type == 'Atom')
This is not the OOP way.
Michael Bemmerl commented
You're right, this is indeed not the OOP way. There's some discussion on this topic in #3 also.
Patches are always welcome. 😄