mibe / FeedWriter

PHP Universal Feed Generator

Home Page:http://ajaxray.com/blog/php-universal-feed-generator-supports-rss-10-rss-20-and-atom

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Namespacing preferences?

brennen opened this issue · comments

Howdy. I was thinking about forking this and making a couple of key changes:

  • Namespace things according to the \VendorName\Namespace\ClassName convention (obviously requires PHP 5.3+)
  • Rely on the assumption that an autoloader following this standard is available.

I'd be happy to issue a pull request, and do the work with that in mind, if there's interest in having those changes on this project. Otherwise I'd probably make it a subset of sparkfun/SparkLib.

If you would like a pull request, what should I use for "vendor name"?

Thanks!

What a coincidence: Last weekend I made some changes to another project to comply with PSR-0. I thought afterwards, hey, this would be something for FeedWriter, too. So yes, I would gladly appreciate a pull request.

Regarding the vendor name: I don't know what name to pick. I'm actually not really the vendor, since I just uploaded @ajaxray's code, which was previously not available on GitHub. I fixed some bugs, though...

Hmm - is it appropriate to just treat the project name as the "vendor", in this instance, or something like that?

I feel like the standard is a bit unclear on this point.

I had the same feeling and eventually used the project name as the vendor.

Cool. I'll send something along in a day or two.

Hello @mibe and @brennen,

Sorry I was busy with some family events and could not respond in issue. However, I am very excited to know that you are using, thinking on and made improvements on it. Thanks to both of you.

About the vendor name, I personally use 'ajaxray' for my libraries. But this class was written long before namespace came in PHP. So, there was no namespace when I uploaded this class.

Waitign for updates from brennen.

Thanks

Anis