directories with spaces in names 'one more' are converted to "onespacemore"
cipy opened this issue Β· comments
then saved backed into JSON as "space" ππ»
. goes "dot"
So we need some renaming: .
and ..
are not legal filenames on any system, and other systems have other special characters. The current policy is in config.rs. I'm definitely not doing the right thing, though! π Thoughts on what it should be instead?
I fixed the saving behavior in 726a175, where names should get properly restored. Can you try using a latest
build?
I tested with yaml since I can yank/see the wrong lines faster; the bug seems to be still there. thanks,
Can you give me a concrete file that goes wrong, and tell me what you expect it to do?
nothing more than:
- creating a new file '{}' by hand (btw: --new gives an error)
- the loading ffs with it, -o anotherfile
- create directories containing spaces in their name "some thing"
- umount, go to 2.
- all directories have now "somespacething" and files somedotsh
btw, is it possible to compare against '.' and '..' and remove them from dir list?
Can you please create a new issue with (a) how you're invoking ffs --new
and (b) the error you're getting?
Just to check: in (4), by "go to 2" you mean load anotherfile
in ffs
?
What do you mean by "remove them from the dir list"? It's important that calls to readdir
return those entries. Did you mean just filtering out .
and ..
named properties?
Yes, filtering.
Got it. My plan is the following:
- cfb8790 do as little name munging as possible (we can just keep spaces, etc.)
- cfb8790 rename
.
and..
files tosomething clear_.
and_..
, respectively - f2dc69a add options to control whether entries with bad names are munged or filtered
- fed1a4e test filenames with spaces
I'm thinking --munge rename
or --munge filter
to control things. I think I'd rather have renaming be the default, so that the data are at least there.
I'm going to merge #41 now---please download a new latest
once it's built and test things out.