Ensure that the "this" reference is set properly in aspects

Question

Ensure that the "this" reference is set properly in aspects

matthewadams opened this issue 6 years ago · comments

It appears that the this reference is not being set to reference the instance of an aspect.

See https://github.com/matthewadams/aspect.js-babel7-poc/tree/aspect-this for a failing test case, specifically https://github.com/matthewadams/aspect.js-babel7-poc/blob/aspect-this/src/main/aspects/Aspect.js.

Matthew Adams · Answer 1 · Thu Nov 15 2018 07:54:02 GMT+0800 (China Standard Time)

Failing test for this issue is now in #77

Minko Gechev · Answer 2 · Mon Nov 19 2018 03:50:45 GMT+0800 (China Standard Time)

The tests were failing because of misusage of resetRegistry. I'll close this, for now, let me know if I'm missing something.

Matthew Adams · Answer 3 · Mon Nov 19 2018 03:57:30 GMT+0800 (China Standard Time)

@mgechev What was the incorrect use of resetRegistry? Is #77 resolved, then?

Minko Gechev · Answer 4 · Mon Nov 19 2018 04:22:37 GMT+0800 (China Standard Time)

Let me merge #77. The issue was a mess with the external advice being applied to classes from other test suits. I just made the selectors in the external advice more restrictive and removed a redundant resetRegistry. Now the tests are working as expected.