meteor-vue / vue-meteor

🌠 Vue first-class integration in Meteor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Meteor 1.8.2 lots of console logs "module Module {id: "/imports/ui/..."

wildhart opened this issue · comments

Since upgrading to Meteor 1.8.2 I'm getting a browser console log message whenever a Vue file is imported:

Screenshot from 2019-12-11 03-37-02

Looks like it's coming from this line:

js += 'module.exportDefault = function(value) { __vue_script__ = value; }; (function(){ if (!module.watch) {console.log(\'module\', module);} ' + script + '\n})();'

Where is module.watch coming from and how do I set it to true?

Should that console.log still be in the code?

Wow. I just found this code too. It s weird because this code is there since two years already. ‘module.watch’ changed recently ? I hope we can set an option to enable/disable this.

@akanix42 added this console.log in this commit: 53deae6. @akanix42, can you explain where module.watch comes from what what we can do about this? Are you happy for me to submit a PR to remove the console.log, or do you want to?

@Akryum do you have any idea ?

Here's the relevant PR: #297. I don't recall the specifics of module.watch, but it's a Meteor core thing. As for the log, yes please remove that. It's leftover from debugging. 🤦‍♀️

Done. PR #383