metaregistrar / php-epp-client

Object-oriented PHP EPP Client

Home Page:https://www.metaregistrar.com/docs/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SIDN - "organizationName" being set to null in parent constructor of sidnEppContactPostalInfo as It leads to get a null organisationName value

nirmalrp23 opened this issue · comments

In the constructor of the sidnEppContactPostalInfo class, the parameter $organisationName is set to null by default.

parent::__construct($name, $city, $countrycode, null, $street, $province, $zipcode, $type);

Because of this, when we try to get the organization of the contact Handles, we get a null value and we can't find whether the handle type is person or organization. In eppInfoContactResponse, we try to get the getContactCompanyname(), but because of the null value passing it in the constructor, always we are getting a null organisationName value.

I think it should be updated as with $organisationName instead of null.

parent::__construct($name, $city, $countrycode, $organisationName, $street, $province, $zipcode, $type);

Please check and update this.

pull request was merged