Process does not terminate
SmashManiac opened this issue · comments
Describe the bug
When calling metalsmith(__dirname).use(permalinks([...])).build(function(err){if (err) throw err;});
, the build appears successful and execution continues, but node
never terminates upon reaching the end of the main script.
To Reproduce
Steps to reproduce the behavior:
- Update all dependencies to their latest version
- Create a simple JavaScript file with the above code and valid parameters in the main thread.
- Run
node
with the JavaScript file in parameter
Expected behavior
No pending process should remain after execution preventing node to terminate normally.
Screenshots
N/A
Environment
- Windows 7 SP1
- Node.js v11.6.0 with npm 6.5.0-next.0
- (Also reproduced with Node.js v10.9.0 with npm v6.2.0.)
Additional context
This regression was introduced between v1.0.0 and v2.0.0.
This issue was reproduced even after deleting all of the permalinks parameters except pattern
.
I've not been able to recreate this issue but we'd gladly accept a PR.
After further investigation, the description of this issue is incorrect. I've closed it and opened #94 as a replacement.