normalize() has to be run on the linksets to convert their "date" option to a function

Question

normalize() has to be run on the linksets to convert their "date" option to a function

rse opened this issue 8 years ago · comments

Dr. Ralf S. Engelschall commented 8 years ago

When using the recently introduced linksets feature, an error is given: "TypeError: options.date is not a function". This is because normalize() internally is not called on the linksets. As a quickfix I've added find(linksets, function(ls) { normalize(ls) }) below the line var linksets [...] in function plugin [...]. Please either apply this fix or make an alternative one. But without this using the linksets feature is broken AFAIK.

David Boyer · Answer 1 · Wed Feb 10 2016 05:45:01 GMT+0800 (China Standard Time)

Just ran into this as well myself. Really does need looking at, I've waited ages for permalinks to support collections, finally spotted that it's been added with multiple linksets and now there's another roadblock in the way.

Adrien · Answer 2 · Wed Mar 09 2016 14:35:01 GMT+0800 (China Standard Time)

I had the same experience, a simple patch to normalize fixes the problem, #55.

Ali Ok · Answer 3 · Wed Mar 09 2016 18:43:39 GMT+0800 (China Standard Time)

👍 Same problem here.

Ringo De Smet · Answer 4 · Fri Sep 30 2016 06:39:02 GMT+0800 (China Standard Time)

There are 3 pull requests related to this issue: #54, #55 and #56.

Can one of them be merged please, followed by a new release?

Ringo De Smet · Answer 5 · Mon Oct 10 2016 03:41:58 GMT+0800 (China Standard Time)

@ianstormtaylor or @lambtron, would you mind having a look at this?
Or accept some additional maintainers to this repo?

Evgeny · Answer 6 · Thu Dec 22 2016 21:59:50 GMT+0800 (China Standard Time)

@ianstormtaylor @lambtron ping

Pat David · Answer 7 · Thu Feb 02 2017 00:46:04 GMT+0800 (China Standard Time)

Just ran into this myself, adding support for merging one of the PR's that fixes it, pretty please? :)

David Boyer · Answer 8 · Thu Feb 02 2017 23:40:51 GMT+0800 (China Standard Time)

Nothing back on this issue for quite a while. Starting to think it's not a priority for them anymore.

Evgeny · Answer 9 · Fri Feb 03 2017 16:19:56 GMT+0800 (China Standard Time)

@ianstormtaylor @lambtron any news?

Sam D · Answer 10 · Thu Feb 21 2019 05:35:14 GMT+0800 (China Standard Time)

Hi,
Sorry to "re-open" this issue (which wasn't closed) but I ran into this too with metalsmith-permalinks 2.1.0. Is it possible to fix this with one of the proposed PR?
Thanks!