Migrate codebase to ES8/TypeScript?

Question

Migrate codebase to ES8/TypeScript?

ZeevKatz opened this issue 4 years ago · comments

What do you think guys about migrating Zdog codebase to ES8/TypeScript? 💪
It will improve coding time and let new people that want to contribute this project an easier start point.

Dmytro Demensky commented 4 years ago

@desandro

Dmytro Demensky · Answer 1 · Sat Aug 08 2020 20:55:30 GMT+0800 (China Standard Time)

I think this is a good idea. But migrating this codebase to typescript can be more difficult than reimplementing the library. If you want to use it with typescript you can install the definitions.

Zeev Katz · Answer 2 · Sun Aug 09 2020 00:01:19 GMT+0800 (China Standard Time)

@demensky My suggestion was not for using Zdog with TypeScript but to improve the codebase and encourage contribution.
I can take the challenge but we’ll need to do it step-by-step and keep a long live branch until we finish, what do you think?

Dmytro Demensky · Answer 3 · Sun Aug 09 2020 00:36:03 GMT+0800 (China Standard Time)

Let's try.

Zeev Katz · Answer 4 · Sun Aug 09 2020 00:57:17 GMT+0800 (China Standard Time)

@demensky Can you please open a new branch for this? (migrate-to-typescript)

Dmytro Demensky · Answer 5 · Sun Aug 09 2020 01:06:46 GMT+0800 (China Standard Time)

I do not have permission for this repository. I was just creating definitions.

Zeev Katz · Answer 6 · Mon Aug 24 2020 04:28:51 GMT+0800 (China Standard Time)

@desandro ?

David DeSandro · Answer 7 · Sat Nov 28 2020 05:14:39 GMT+0800 (China Standard Time)

I'm open to migrating to ES8. This will likely happen in the next major version upgrade
Yes, I should add TypeScript definition at least. But I prefer keeping the source code in vanilla JavaScript that can be run right in the browser without compilation.

I've been taking a break from Metafizzy development. I may evaluate this in 2021