mesosphere-backup / mesos-cli

This project has been deprecated. Please use the DC/OS CLI.

Home Page:https://github.com/mesosphere/dcos-cli

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

add mesos.protocol to setup.py

elee opened this issue · comments

mesos.protocol seems to have been omitted from setup.py

after issuing a pip install -e . && mesos from the checkout root:

$ mesos
Traceback (most recent call last):
  File "/usr/local/bin/mesos", line 9, in <module>
    load_entry_point('mesos.cli==0.0.0', 'console_scripts', 'mesos')()
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 337, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2279, in load_entry_point
    return ep.load()
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 1989, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/home/ubuntu/sf/mesos-cli/mesos/cli/main.py", line 21, in <module>
    from . import cli
  File "/home/ubuntu/sf/mesos-cli/mesos/cli/cli.py", line 25, in <module>
    from .master import current as master
  File "/home/ubuntu/sf/mesos-cli/mesos/cli/master.py", line 23, in <module>
    import mesos.protocol.mesos_pb2
ImportError: No module named protocol.mesos_pb2
$

Adding this line:

$ git diff
diff --git a/setup.py b/setup.py
index 23c561f..f7ae7cc 100644
--- a/setup.py
+++ b/setup.py
@@ -28,6 +28,7 @@ requires = [
     "importlib>=1.0.3", # py26
     "kazoo>=2.0",
     "mesos.interface>=0.20.0",
+    "mesos.protocol>=0.20.0",
     "ordereddict>=1.1", # py26
     "prettytable>=0.7.2",
     "protobuf>=2.5.0,<3",
$

and re-running pip install -e . allows me to run mesos without encountering the same error.

Sorry about that, mesos.protocol was the temporary name for mesos.interface. I'm trying to get this all merged into mesos proper and forgot to update here.

I've made sure the mesos.protocol references have been updated, give it a try without and should work.

ps. Would love to hear your feedback on how it works for you =)

the fix looks good! backing out my changes and doing a fresh pip install -e . yields a working mesos on my path