memorysafety / sudo-rs

A memory safe implementation of sudo and su.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

use `std::os::unix::fs::fchown`

japaric opened this issue · comments

instead of the unsafe libc::fchown. this API will be stabilized in Rust 1.73 (~ 2023-10-05)

cerr(unsafe { libc::fchown(fd, owner, group) }).map(|_| ())

I would suggest we only do this once our MSRV increases past this version some time in the future, and not increase our MSRV just because of this feature.

Maybe we can introduce some labels for issues that have to wait only because of a MSRV-related issue?

@squell maybe we could do milestones for these so we can actually track the specific version for each issue, what do you think?