meilisearch / milli

Search engine library for Meilisearch ⚡️

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Put nightly CI in a cron CI

curquiza opened this issue · comments

Are the nightly CIs really useful for you?

Because, even if they are not Required by GitHub to be merged and even if Bors does not take them into account to merge, it makes our CIs generally slower by taking the available resources GitHub provides for our repo CIs.

Capture d’écran 2022-04-11 à 19 29 25

Source: https://docs.github.com/en/enterprise-cloud@latest/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits

FYI, we are on Team plan, meaning we only have 5 jobs for macos

Knowing we have 2 jobs running for macos per PR (nightly + stable), and then bors will run 1 on staging, it means we often have jobs waiting like this in the queue because of this limit:

Capture d’écran 2022-04-11 à 19 26 46

This happens regularly since we have often multiple PRs on milli, especially during pre-release and at the end of the sprint 🙂

So, that's why I ask, is it a really useful to keep the nightly CI, or could we remove them? 😇

Thank you for this issue report,

I would say that we were using the nightly CI to be sure to catch possible breaking changes between the stable and nightly. We never noticed anything. The nightly CI could also be used to test nightly-only features (like for Roaring and SIMD) but we never set up that.

So, I would say that we do not really need this nightly build CI, at least for now.

What do you think if we run a CI every week with nightly?

I think that it could be great, it will help us find the possible breaking changes with Rust nightly, and it will not blow up our CI plan!