Use chrono
irevoire opened this issue · comments
Use chrono to deserialise everything related to date and timestamp
Chrono is currently not maintained and should be forked. We will not force users to add this untrustable dependency. They can already parse dates if they want to. If chrono maintainance status changes in the future, we might want to reconsider this
How is it not maintained? I can’t find anything about it?
And since MeiliSearch already use it, if there is any problem with chrono it’s going to crash MeiliSearch before it crashes the sdk no?
Look at their inactive github repo. Nobody answers issues and nobody fixes them. Dependencies are critically outdated. A vulnerability was found in chrono a few months ago and extreme fear began to spread in the rust community. I'm not even sure it's fixed now. I really hope this problem is solved soon but as of today, I don't think one should use chrono.
Hey @Mubelotix, I was scrolling on the chrono issues, and I’ve seen most people are moving to time; what do you think of this one?
From what I see, it should be enough for us, and chrono was actually depending on it.
Hey @Mubelotix, I was scrolling on the chrono issues, and I’ve seen most people are moving to time; what do you think of this one? From what I see, it should be enough for us, and chrono was actually depending on it.
Hi @irevoire, sorry for the late reply; notification got lost. That's exactly what I was going to suggest after reading this thread
Well now it’s done 👍
I also moved meilisearch and milli from chrono to time so thanks for your comment.