meilisearch / meilisearch-php

PHP wrapper for the Meilisearch API

Home Page:https://meilisearch.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Switch phpunit assertion arguments

norkunas opened this issue · comments

PHPUnit expects first argument to be the expected data and the second one as actual but I found in most tests where I did look that they are switched and the expected data is provided as a second argument

I'll reopen it since the issue was not entirely fixed.

There are still some places where it should be updated, like in the asserSame usages e.g.:

  • $this->assertSame($response['type'], 'documentAdditionOrUpdate'); at tests/Endpoints/IndexTest.php lines 205, 244 and more.