meilisearch / meilisearch-js-plugins

The search client to use Meilisearch with InstantSearch.

Home Page:https://www.meilisearch.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve code coverage during tests

bidoubiwa opened this issue · comments

The coverage is pretty good but some specific files are missing some lines. These should be tested as well

-------------------------------------|---------|----------|---------|---------|-------------------
File                                 | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-------------------------------------|---------|----------|---------|---------|-------------------
All files                            |      95 |    90.72 |   83.33 |   94.78 |                   
 src                                 |     100 |      100 |     100 |     100 |                   
  index.ts                           |     100 |      100 |     100 |     100 |                   
 src/adapter/search-request-adapter  |     100 |    90.14 |     100 |     100 |                   
  search-params-adapter.ts           |     100 |    89.55 |     100 |     100 | 23,29,35,42-44,56 
  search-resolver.ts                 |     100 |      100 |     100 |     100 |                   
 src/adapter/search-response-adapter |   95.65 |       75 |     100 |   95.65 |                   
  pagination-adapter.ts              |     100 |      100 |     100 |     100 |                   
  search-response-adapter.ts         |   94.44 |    66.67 |     100 |   94.44 | 29                
 src/client                          |   76.19 |      100 |      50 |   76.19 |                   
  instant-meilisearch-client.ts      |   76.19 |      100 |      50 |   76.19 | 78-87             
 src/contexts                        |     100 |      100 |     100 |     100 |                   
  index.ts                           |     100 |      100 |     100 |     100 |                   
  pagination-context.ts              |     100 |      100 |     100 |     100 |                   
  search-context.ts                  |     100 |      100 |     100 |     100 |                   
 tests/assets                        |     100 |      100 |     100 |     100 |                   
  utils.ts                           |     100 |      100 |     100 |     100 |                   
-------------------------------------|---------|----------|---------|---------|-------------------
Test Suites: 30 passed, 30 total
Tests:       274 passed, 274 total
Snapshots:   0 total
Time:        3.041 s, estimated 5 s

Hello @bidoubiwa I am investigating this as part of the hacktoberfest. I have couple questions that I need your guidance.

Here is the screenshot of coverage report from this project with latest changes;
CleanShot 2022-10-10 at 02 16 40@2x

The screenshot you shared above are not matching with the current coverage (i.e., src/adapter/search-request-adapter seems fully covered). Maybe I still can take the current uncovered lines into consideration ?

Hey @batunpc! Yes, the rest should still be covered :) Thanks for your interest 🔥