crash at startup

[patrykq112]

Priority

Critical

Area

• Data
• Source
• Docker
• Other

What happened?

client crashes on startup after commit "perf: more fps and less memory usage"

What OS are you seeing the problem on?

Linux, Windows, MacOS

Code of Conduct

• I agree to follow this project's Code of Conduct

[Renato Machado]

Did you clean the project and compile it, or just recompile it?

[patrykq112]

I cleaned and compiled

[Renato Machado]

try this:

in otclient\src\framework\core\graphicalapplication.cpp

replace for

    // THREAD - FOREGROUND UI
    threads.emplace_back(g_asyncDispatcher.submit_task([&] {
        std::unique_lock lock(uiPool->getMutexPreDraw());
        uiCond.wait(lock, [this]() {
            if (m_drawEvents->canDraw(DrawPoolType::MAP))
                g_ui.render(DrawPoolType::FOREGROUND);
            return m_stopping;
        });
    }));

    // THREAD - FOREGROUND MAP
    threads.emplace_back(g_asyncDispatcher.submit_task([&] {
        std::unique_lock lock(fgMapPool->getMutexPreDraw());
        fgMapCond.wait(lock, [this]() -> bool {
            if (m_drawEvents->canDraw(DrawPoolType::MAP))
                m_drawEvents->drawForgroundMap();
            return m_stopping;
        });
    }));
    ```

[patrykq112]

this replacement helped, it no longer crashes at the start

[patrykq112]

@mehah I found one more bug after this update. When opening a backpack, layout:getNumLines() always returns 0 and the backpacks open at the wrong height.

[Renato Machado]

@patrykq112

try this:
add internalUpdate() at the end of the UIGridLayout::applyStyle() method

like this:

[patrykq112]

it didn't help, still the same

[Renato Machado]

Could you give me an example, where are you executing this method so I can test it?

because everything seems normal to me.

[Renato Machado]

@patrykq112
hmm, try this:
add

    if (m_parentWidget)
        m_parentWidget->onLayoutUpdate();

[patrykq112]

Could you give me an example, where are you executing this method so I can test it?

because everything seems normal to me.

game_containers/containers.lua

containerWindow:setContentMaximumHeight(cellSize.height * layout:getNumLines())

[patrykq112]

@mehah

2024-05-14.13-12-55.mp4

[patrykq112]

I found one more bug, the character names shake a lot when walking (it's most noticeable when moving at high speed)

[Renato Machado]

@mehah

2024-05-14.13-12-55.mp4

fixed 6da6645

I found one more bug, the character names shake a lot when walking (it's most noticeable when moving at high speed)

I will look into this problem.

[Renato Machado]

I found one more bug, the character names shake a lot when walking (it's most noticeable when moving at high speed)

fixed 84dca80