mehah / otclient

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Using top ground item not working!

Nottinghster opened this issue · comments

Priority

High

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

I recorded two videos showing an example, check below:

OTClient Redemption (not working)

OTClient.-.Redemption.2024-01-06.10-14-05.mp4

OTClient v8 (working)

OTCv8.-.GOD.Nottinghster.2024-01-06.10-15-16.mp4

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct

Tile::getTopUseThing() in Mehah ( https://github.com/mehah/otclient/blob/main/src/client/tile.cpp#L418 ):

if (!thing->isGround() && !thing->isGroundBorder() && !thing->isCreature() && !thing->isSplash())

in OTCv8 ( https://github.com/OTCv8/otcv8-dev/blob/master/src/client/tile.cpp#L531):

if (!thing->isSplash() && !thing->isCreature())

as you can see, Mehah skips over ground border items (!thing->isGroundBorder()) ex. carpet and goes to return m_things[0];, which make it send 'use ground item' to server.

IDK if ground border item should be usable or not. Maybe there are some reasons for some protocol versions (with different Tibia.dat attributes).

@gesior

Thanks for your help, you're the greatest