Application wide problem with rate limit
mark-sercombe opened this issue · comments
Describe the bug
It seems that almost every module will return rate limit true when anything unexpected happens instead of telling the user there was an error. This way many modules that have broken now always return ratelimit true even though they aren't actually rate limited. Proper checks for rate limits should be implemented instead of defaulting to it. This will make it much more clear as to what is happening and which modules need fixing instead of people changing their ip without results.
Expected behavior
The application only reports a module is rate limited when it actually is instead of when something goes wrong.
This is a rather large task to fix but it will result in quicker detection of broken modules and better feedback to the user.
I agree. 2 solutions came to my mind. First - add another status like "[ ! ] Error". Second - print anything that is stored in "others" variable. Currently the content of this variable is printed only when the email exists and it contains creation date or the name.
I'm currently working on it. I have been able to fix instagram, yahoo and adobe modules.
I agree with @P3run, they are both good ideas. Maybe print "[!] Error" and put a new cli boolean flag to display the Exception stored in "others" for future debugging purposes. I don't know how hard would it be to implement it though
It doesn't seem to be difficult. I can try to implement it.