Rename in javascript does not work when mdx.experimentalLanguageServer is enabled
ambarvm opened this issue · comments
Initial checklist
- I read the support docs
- I read the contributing guide
- I agree to follow the code of conduct
- I searched issues and couldn’t find anything (or linked relevant results below)
Affected packages and versions
unifiedjs.vscode-mdx v1.3.0
Link to runnable example
No response
Steps to reproduce
- Enable
mdx.experimentalLanguageServer
"mdx.experimentalLanguageServer": true
- Open a project in vscode containing both javascript and mdx files
- Open a javascript file and right click a variable. Click "Rename Symbol".
Expected behavior
An input box should appear to allow the variable rename operation.
Actual behavior
A tooltip appears saying "The element can't be renamed."
![image](https://private-user-images.githubusercontent.com/44284655/247952472-23d9b051-3d79-4795-a258-d3f082085c8e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDg2Njk1ODgsIm5iZiI6MTcwODY2OTI4OCwicGF0aCI6Ii80NDI4NDY1NS8yNDc5NTI0NzItMjNkOWIwNTEtM2Q3OS00Nzk1LWEyNTgtZDNmMDgyMDg1YzhlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjIzVDA2MjEyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk2NDc4Yzk4ODk2ZmU0Mzg3YTRiY2ExNGM4MjVmYTBjMGQ4ZjVlZDg3OTUzMzNkMWExNTk0ZTc4YjcwOTE3M2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sxY3EtKGaU6IyybOD6K4QkK8Hk8bHxTDmiqYLw4_kJk)
Runtime
Node v18
Package manager
npm v9
OS
macOS
Build and bundle tools
webpack
I just enabled version 1.5.0 of the VS Code extension. The implementation got a complete rewrite. This issue should be resolved. Please report a new issue if this problem still persists.
Hi! This was closed. Team: If this was fixed, please add phase/solved
. Otherwise, please add one of the no/*
labels.