HTML validation errors

Question

HTML validation errors

szepeviktor opened this issue 9 years ago · comments

Please change width="160px" to width="160" in <iframe>.
Please display &repo=bootstrap instead of &repo=bootstrap.
https://validator.w3.org/nu/?doc=https%3A%2F%2Fghbtns.com%2F
Please consider not suggesting non-HTML5 iframe attributes.

Thank you!

ahtee · Answer 1 · Thu Jun 07 2018 20:40:14 GMT+0800 (China Standard Time)

I dont see any px in the actual code (index.md), not sure how it was added when brought togther and displayed on the page..

Viktor Szépe · Answer 2 · Thu Jun 07 2018 20:46:58 GMT+0800 (China Standard Time)

Could it be Jekyll?

XhmikosR · Answer 3 · Mon Jan 14 2019 07:40:49 GMT+0800 (China Standard Time)

It's just the gh-page branch is behind master I think.

Viktor Szépe · Answer 4 · Fri Apr 24 2020 03:34:57 GMT+0800 (China Standard Time)

2020-04-23

XhmikosR · Answer 5 · Fri Apr 24 2020 03:35:44 GMT+0800 (China Standard Time)

It's fixed in master, it'll be pushed soon.

XhmikosR · Answer 6 · Fri Apr 24 2020 03:36:17 GMT+0800 (China Standard Time)

https://mdo-8674181fab.drafts.github.io/github-buttons/

Viktor Szépe · Answer 7 · Fri Apr 24 2020 03:37:57 GMT+0800 (China Standard Time)

Thank you.

Almost there! Ampersands need to be encoded.

XhmikosR · Answer 8 · Fri Apr 24 2020 03:39:08 GMT+0800 (China Standard Time)

Nah, the ampersands are fine, we use utf-8: https://validator.w3.org/nu/?doc=https%3A%2F%2Fmdo-8674181fab.drafts.github.io%2Fgithub-buttons%2F